Dan Kenigsberg has posted comments on this change. Change subject: Added a support for a guest hibernate command. ......................................................................
Patch Set 4: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/API.py Line 335: def guestHibernate(self, vmId, state='disk'): what is the point of the 'state' argument here? which values are expected for it? .................................................... File vdsm/vm.py Line 824: def _shutdownCommand(event_str, timeout_var, guest_command, *kargs): no 'self' in arg list. please test your code before submitting it. *args **kwargs -- To view, visit http://gerrit.ovirt.org/1121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
