Dan Kenigsberg has posted comments on this change. Change subject: Added blkid tool support in supervdsm. ......................................................................
Patch Set 2: (2 inline comments) two minor comments .................................................... File vdsm/blkid.py Line 29: rc, out, err = utils.execCmd([constants.EXT_BLKID, "-c", "/dev/null"], this case is redundant - it is just like the former when devList is empty. Line 31: if rc: it would be more pythonic to raise a BlockIDError exception here, I believe. -- To view, visit http://gerrit.ovirt.org/2185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
