Dan Kenigsberg has posted comments on this change.
Change subject: Added blkid tool support in supervdsm.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/blkid.py
Line 33: blkIdDict = {}
let's keep unittest'ing in mind: how about separating the parsing to a
different function, so we can add a little test for its handling of blkid's
output?
P.S. are we sure there's no evil escaping issues in blkid's output?
--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
