Dan Kenigsberg has posted comments on this change.
Change subject: Added blkid tool support in supervdsm.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/blkid.py
Line 33: blkIdDict = {}
it should handle the craziest output of Fedora blkid, and raise an exception in
any other case.
the man page for blkid speaks about
-d Don't encode non-printing characters. The non-printing charac‐
ters are encoded by ^ and M- notation by default.
You should decode this, or at least add a comment why this is not important for
our use case.
What happens if a disk label has the space or the double-quote character inside
it? It would break your parsing if space is not encoded by blkid (I do not know
if it is).
--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
