Federico Simoncelli has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
......................................................................
Patch Set 10: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File configure.ac
Line 131: AC_PATH_PROG([GLUSTER_CLI_PATH], [gluster], [/usr/sbin/gluster])
I'm trying to phase out these, could you try to use utils.CommandPath both for
/usr/sbin/gluster and /bin/hostname? You can find an example in vdsm/qemuImg.py.
....................................................
File vdsm/gluster/gluster_exception.py
Line 363: if __name__ == "__main__":
This was moved to a test, could you unify it?
....................................................
File vdsm/gluster/__init__.py.in
Line 24: sys.path.append('@VDSMDIR@')
What issue are you trying to solve here? This is a no-go for me, imported
modules should not touch the sys.path. Can you explain the problem? We can try
to find a better solution.
....................................................
File vdsm.spec.in
Line 491: %{_datadir}/%{vdsm_name}/vdsm_exception.py*
This should be probably moved to the vdsm-python package. I'm not sure if I
like the vdsm_ prefix (looks useless since it will be imported as
vdsm.exception).
Line 780: %{_datadir}/%{vdsm_name}/gluster/gluster_exception.py*
There's no need to repeat gluster twice (all the imports would be gluster.cli
and glister.exceptions anyway right?). Could you rename both files? Thanks.
--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
