Dan Kenigsberg has posted comments on this change. Change subject: Added gluster cli support in supervdsm. ......................................................................
Patch Set 8: (3 inline comments) .................................................... File vdsm/gluster/gluster_cli.py.in Line 457: rv, out, err = utils.execCmd([_EXT_HOSTNAME, '--fqdn']) rv ?? has this passed pylakes? .................................................... File vdsm/supervdsmServer.py Line 263: for name in dir(gcli): much more like it. Future improvement may be a decorator in gcli, that marks all supervdsm-accessible methods. Line 265: if types.FunctionType == type(func) and \ callable(func) is prettier, right? -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
