Bala.FA has posted comments on this change. Change subject: Added gluster cli support in supervdsm. ......................................................................
Patch Set 8: (2 inline comments) New patch set has been sent already with these fixes .................................................... File vdsm/gluster/gluster_cli.py.in Line 457: rv, out, err = utils.execCmd([_EXT_HOSTNAME, '--fqdn']) Done .................................................... File vdsm/supervdsmServer.py Line 265: if types.FunctionType == type(func) and \ according to help(callable), class is also callable. So it doesn't solve the purpose. But having a decorator is good to go. -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
