Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Added gluster cli support in supervdsm. ......................................................................
Patch Set 21: Looks good to me, but someone else must approve (4 inline comments) Just minor points, looks good otherwise. .................................................... File vdsm/gluster/exception.py Line 88: message = "storage devices list failed" Minor: the lowercase is a bit inconsistent here. Line 91: GlusterGeneralException.__init__(self, 0, [], []) This constructor doesn't add anything. Line 363: message = "get gluster host list failed" Minor: lowercase again. .................................................... File vdsm/gluster/hostname.py Line 38: rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn']) How does this compare to socket.getfqdn(socket.gethostname())? -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
