Federico Simoncelli has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
......................................................................
Patch Set 22: (2 inline comments)
....................................................
File vdsm/gluster/cli.py
Line 33: _EXT_GLUSTER_CLI = _glusterCommandPath.cmd
This has the same problem that hostname had. It makes the lazy evaluation
useless.
....................................................
File vdsm/gluster/hostname.py
Line 38: rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn'])
The command hostname uses uname to find the hostname:
$ strace -e trace=uname hostname
uname({sys="Linux", node="vm-rhdev1...", ...}) = 0
The equivalent in python is:
$ python -c "import os;print os.uname()"
('Linux', 'vm-rhdev1...', '2.6.32-259.el6.x86_64', '#1 SMP Thu Mar 29 12:14:22
EDT 2012', 'x86_64')
--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
