Bala.FA has posted comments on this change. Change subject: Added gluster cli support in supervdsm. ......................................................................
Patch Set 22: (3 inline comments) .................................................... File vdsm/gluster/cli.py Line 33: _EXT_GLUSTER_CLI = _glusterCommandPath.cmd Fix is on the way .................................................... File vdsm/gluster/hostname.py Line 38: rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn']) 'hostname --fqdn' does more according to the man page. I don't have any idea to implement python equivalent now. Line 38: rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn']) Yes. But 'strace hostname --fqdn' does more. -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
