Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Added gluster cli support in supervdsm. ......................................................................
Patch Set 22: (1 inline comment) .................................................... File vdsm/gluster/hostname.py Line 38: rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn']) socket.getfqdn() does return the fqdn. It will call socket.gethostbyaddr(socket.gethostname()) and then go through the hostname and all aliases. Then picks the first with a dot in it and fall back to the hostname. For all well configured networks this I think this is the correct result, but I don't know how it behaves for some of the weirder setups people might have. man 2 uname is rather vague about how it determines the name. I would prefer pure python over calling system binaries, but would be interested to know if Federico thinks the same. -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
