Dan Kenigsberg has posted comments on this change. Change subject: Don't ignore nfs_mount_options in vdsm.conf ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/fileUtils.py Line 44 lovely. a never-used constant. there must be a python tool to find those. .................................................... File vdsm/storage/storageServer.py Line 256: for opt in confOptions: blindly adding conf options on top of DEFAULT_OPTIONS does not sound right (they may be in compatible). maybe *replace* DEFAULT_OPTIONS with NFS_OPTIONS from the conf file. but please talk to Saggi/Ayal -- To view, visit http://gerrit.ovirt.org/5368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
