Greg Padgett has posted comments on this change. Change subject: Don't ignore nfs_mount_options in vdsm.conf ......................................................................
Patch Set 2: Dan Kenigsberg write: > blindly adding conf options on top of DEFAULT_OPTIONS does > not sound right (they may be in compatible). > > maybe *replace* DEFAULT_OPTIONS with NFS_OPTIONS from the > conf file. > > but please talk to Saggi/Ayal Patch set 2 overrides options from engine if the nfs_mount_options parameter is supplied in vdsm.conf. I removed the config object's default initialization of this option so that config.has_option() would reflect the status in the .conf file for nfs_mount_options (otherwise it would always return true). Alternatively, we could add a new option in vdsm.conf, a boolean specifying whether or not to override. (I'm sure there are more possibilities, this is just one idea...) Saggi/Ayal/Dan, any thoughts on the best approach or if this patch set is suitable? Thanks. -- To view, visit http://gerrit.ovirt.org/5368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
