Dan Kenigsberg has posted comments on this change. Change subject: Don't ignore nfs_mount_options in vdsm.conf ......................................................................
Patch Set 2: I would prefer that you didn't submit this having the static config file option override run-time, server-specific (though not host-specific) option is a very peculiar semantics. Do you really want this behavior? Why is this patch needed? to override timeout, retrans, and version passed by Engine? or to add more exotic options? I'm not nacking it, just trying to understand the use case. Maybe you would like to add/override mount options specifically. -- To view, visit http://gerrit.ovirt.org/5368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
