Shu Ming has posted comments on this change.
Change subject: Offset by one for UUID position
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 61: # sdUUID position after data-center
Line 62: sdUUIDPos = 3
Line 63:
Line 64: metaList = metafile.split('/')
Line 65: sdUUID = len(os.path.normpath(config.get('irs',
'repository')).split('/')) - 1 + sdUUIDPos
"sdUUIDPos" does have meaning of the position of "sdUUID" after "data-center".
It is reasonable to make it "3". Also, it is wrong to use the length of the
'repository path as the position of "data-center". So I make the length offset
by one here. I happened to find this bug when I was debugging the storage
service to print the value of "metaList[sdUUID]".
Line 66: return metaList[sdUUID]
Line 67:
Line 68: class FileMetadataRW(object):
Line 69: """
--
To view, visit http://gerrit.ovirt.org/7078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
