Federico Simoncelli has posted comments on this change.
Change subject: fileSD.getDomUuidFromMetafilePath: return correct sdUUID
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 66: def getDomUuidFromMetafilePath(metafile):
Line 67: # Metafile path has pattern:
Line 68: # /rhev/data-center/mnt/export-path/sdUUID/dom_md/metadata
Line 69:
Line 70: metaList = metafile.split('/')
Let's just hope that we never build paths with double "/", eg:
>>> "/export-path/sdUUID//dom_md/metadata".split("/")
['', 'export-path', 'sdUUID', '', 'dom_md', 'metadata']
Line 71: return metaList[-3]
Line 72:
Line 73:
Line 74: class FileMetadataRW(object):
--
To view, visit http://gerrit.ovirt.org/7078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
