Federico Simoncelli has posted comments on this change. Change subject: Offset by one for UUID position ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/fileSD.py Line 108: self.mountpoint = os.path.dirname(domainPath) Line 109: self.remotePath = os.path.basename(self.mountpoint) Line 110: self.metafile = os.path.join(domainPath, sd.DOMAIN_META_DATA, sd.METADATA) Line 111: Line 112: metadata = FileSDMetadata(self.metafile) Is there any reason why we don't pass the sdUUID here? Is it because it would be asymmetric with the block metadata providers? IMHO it's a small argument compared to what it forces us to do in getDomUuidFromMetafilePath. Line 113: sdUUID = metadata[sd.DMDK_SDUUID] Line 114: domaindir = os.path.join(self.mountpoint, sdUUID) Line 115: sd.StorageDomain.__init__(self, sdUUID, domaindir, metadata) Line 116: -- To view, visit http://gerrit.ovirt.org/7078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
