Dan Kenigsberg has posted comments on this change. Change subject: Offset by one for UUID position ......................................................................
Patch Set 2: I would prefer that you didn't submit this Shu Ming, I was probably not clear in my previous comment: find that metaList[-3] would be a more robust way to get to spUUID - without worrying whether the configurable ends with a slash or not. Could you also explain how you have verified your fix? -- To view, visit http://gerrit.ovirt.org/7078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
