Deepak C Shetty has posted comments on this change.
Change subject: add simple VM creation functional test
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File tests/functional/vmTests.py
Line 40: kernelPath = "/boot/vmlinuz-" + kernelVer
Line 41: initramfsPath = "/boot/initramfs-%s.img" % kernelVer
Line 42: vmid = str(uuid.uuid4())
Line 43: conf = {'acpiEnable': 'True',
Line 44: 'display': 'vnc',
How does acpi and vnc display add value here ?
Reg. vnc, Why un-necessary have qemu open up a vnc port when it won't be used
at all.
Line 45: 'initrd': initramfsPath,
Line 46: 'kernel': kernelPath,
Line 47: # Fedora uses dracut to create initramfs. The following
Line 48: # arguments will be interpreted by init scripts
created by
Line 52: 'memSize': '256',
Line 53: 'vmId': vmid,
Line 54: 'vmName': 'vdsm_testVM',
Line 55: 'vmType': 'kvm'}
Line 56:
How does this test in general help ? Even the simplest of VM created using VDSM
would use storage domain and drives pointing to vmdisk on the domain.. without
them I am not sure how valuable the test would be ?
Line 57: self.s = vdscli.connect()
Line 58:
Line 59: try:
Line 60: assertVdsOK(self.s.create(conf))
Line 72: time.sleep(1)
Line 73: except Exception:
Line 74: raise
Line 75: finally:
Line 76: assertVdsOK(self.s.destroy(vmid))
IIUC, destroy will be called even if VM failed to come up, which will cause
another excp to be seen. VM should be destroyed only if it was successfully
created.
Line 77:
Line 78: def isVMUp(self, vmid):
Line 79: vmList = assertVdsOK(self.s.list())['vmList']
Line 80: for vm in vmList:
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
