Michal Skrivanek has posted comments on this change. Change subject: add simple VM creation functional test ......................................................................
Patch Set 1: No score (1 inline comment) .................................................... File tests/functional/vmTests.py Line 72: time.sleep(1) Line 73: except Exception: Line 74: raise Line 75: finally: Line 76: assertVdsOK(self.s.destroy(vmid)) isn't it better to try to destroy it just in case it's in some weird state. To not affect the other tests. The exception and failure will anyway be there. Line 77: Line 78: def isVMUp(self, vmid): Line 79: vmList = assertVdsOK(self.s.list())['vmList'] Line 80: for vm in vmList: -- To view, visit http://gerrit.ovirt.org/7396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
