Michal Skrivanek has posted comments on this change.
Change subject: add simple VM creation functional test
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File tests/functional/vmTests.py
Line 40: kernelPath = "/boot/vmlinuz-" + kernelVer
Line 41: initramfsPath = "/boot/initramfs-%s.img" % kernelVer
Line 42: vmid = str(uuid.uuid4())
Line 43: conf = {'acpiEnable': 'True',
Line 44: 'display': 'vnc',
normally we do create all of them with SPICE, is it a problem to use it here?
Not sure if it makes any difference though
Line 45: 'initrd': initramfsPath,
Line 46: 'kernel': kernelPath,
Line 47: # Fedora uses dracut to create initramfs. The following
Line 48: # arguments will be interpreted by init scripts
created by
Line 58:
Line 59: try:
Line 60: assertVdsOK(self.s.create(conf))
Line 61:
Line 62: timeout = 60 # seconds
great. I just noticed in momTests.py there is a fixed sleep. While you're at it
feel free to change that to timeout as well. It's always better to run these
tests faster...
Line 63: # wait for VM to come up until timeout
Line 64: start = time.time()
Line 65: while True:
Line 66: if self.isVMUp(vmid):
Line 83: else:
Line 84: return False
Line 85: statsList = assertVdsOK(self.s.getVmStats(vmid))['statsList']
Line 86: vm = statsList[0]
Line 87: if vm['status'] == 'Up':
"return vm['status'] == Up" ?
Line 88: return True
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
