Martin Polednik has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/44767/12/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 289: Request device events from the kernel. Line 290: Line 291: Arguments: Line 292: Line 293: attr_matches A tuple of attribute-value tuples, > No, we don't require a tuple and we should not have incorrect documentation yep, it's quite a correctness issue, cannot say the 'iterable' looks nice though Line 294: expanded like this: Line 295: Line 296: (('a', 'b'), ('c', 'd')) ~> Line 297: --attr-match=a=b --attr-match=c=d -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
