Nir Soffer has posted comments on this change.

Change subject: supervdsm: generalize udevTrigger method
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44767/12//COMMIT_MSG
Commit Message:

Line 11: devnum and busnum, and we should be somewhat able to do both these
Line 12: matches in a more generic function.
Line 13: 
Line 14: This patch refactors udevTrigger to include attr_matches and
Line 15: property_matches. When tuple of attribute-value tuples is sent,
When a tuple of -> when a iteratable of

We dot not care about the of type of property_matches and attr_matches, on ly 
about being able to iterate them.
Line 16: they're expanded to the correct udevadm command.
Line 17: 
Line 18: Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7


-- 
To view, visit https://gerrit.ovirt.org/44767
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to