Nir Soffer has posted comments on this change.

Change subject: supervdsm: generalize udevTrigger method
......................................................................


Patch Set 14: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/44767/14/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 299:                             and cause only events from devices that 
match
Line 300:                             given attributes to be triggered.
Line 301: 
Line 302:         property_matches    Similar to attr_matches, it is an 
iterable of
Line 303:                             attribute-value iterables that expand
We don't iterate over these, so "pairs" is the right description, but it is 
good enough.
Line 304:                             in a similar fashion:
Line 305: 
Line 306:                             (('a', 'b'), ('c', 'd')) ~>
Line 307:                             --property-match=a=b --property-match=c=d


-- 
To view, visit https://gerrit.ovirt.org/44767
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to