Dan Kenigsberg has submitted this change and it was merged. Change subject: supervdsm: generalize udevTrigger method ......................................................................
supervdsm: generalize udevTrigger method udevTrigger in it's current state is tied to storage code as it does property match against DM_NAME. USB devices require attribute match for devnum and busnum, and we should be somewhat able to do both these matches in a more generic function. This patch refactors udevTrigger to include attr_matches and property_matches. When an iterable of attribute-value iterables is sent, they're expanded to the correct udevadm command. Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Signed-off-by: Martin Polednik <[email protected]> Reviewed-on: https://gerrit.ovirt.org/44767 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> --- M vdsm/storage/hsm.py M vdsm/supervdsmServer 2 files changed, 41 insertions(+), 8 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
