Nir Soffer has posted comments on this change. Change subject: ssl: configurable implementation ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/44494/10/vdsm.spec.in File vdsm.spec.in: Line 1072: %{python_sitelib}/%{vdsm_name}/sslcompat.py* Line 1073: %if %{with_m2c} Line 1074: %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1075: %exclude %{python_sitelib}/%{vdsm_name}/sslutils.py* Line 1076: %else > first, in debian you don't use rpm so spec change for that is not relevant. debian cannot work with the m2c, since we depend on fedora/el version which contains features not in upstream or debian version. I think what we need is: rpm based: - package both ssl and m2c - default should be m2c until we are confident that ssl does not introduce performance regression. deb based: - package only ssl, since m2c code is not compatible - default should be ssl since there is no other option When ssl is proven, we can drop m2c compatibility layer and the configuration. So I agree with Yaniv that we don't need to exclude anything here. Line 1077: %exclude %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1078: %{python_sitelib}/%{vdsm_name}/sslutils.py* Line 1079: %endif Line 1080: %{python_sitelib}/%{vdsm_name}/supervdsm.py* -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
