Yaniv Bronhaim has posted comments on this change. Change subject: ssl: configurable implementation ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/44494/10//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-09-15 14:47:04 +0200 Line 6: Line 7: ssl: configurable implementation Line 8: Line 9: We want to choose ssl implementation during build process. > This patch provide ability to choose ssl implementation during build proces for what? why do we need to different implementation? is it debian support fault? Line 10: Line 11: Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 https://gerrit.ovirt.org/#/c/44494/10/vdsm.spec.in File vdsm.spec.in: Line 1072: %{python_sitelib}/%{vdsm_name}/sslcompat.py* Line 1073: %if %{with_m2c} Line 1074: %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1075: %exclude %{python_sitelib}/%{vdsm_name}/sslutils.py* Line 1076: %else > when I compile for debian I do not want any m2c files. They are not going t first, in debian you don't use rpm so spec change for that is not relevant. and having such global that can be modified only manually and not by "configure" is redundant second, I don't connect to this import dependency that you create here. the mail talks about having config value that decides the implementation vdsm will use. debian users should modify the default value and I think its enough to request than having this installation magic tricks that will take care for you which implementation will be available for you to use. I want to keep the same tree both in debian and fedora and have configuration values for the differences - if you want to make the user's life easier you can specify new vdsm-tool configure for debian that sets whatever needed in vdsm.conf for it to work properly. but currently we have just one value and it can stay as a note for the user. if later on engine will provide ability to deploy debian host, the host-deploy will take care of the config values. Line 1077: %exclude %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1078: %{python_sitelib}/%{vdsm_name}/sslutils.py* Line 1079: %endif Line 1080: %{python_sitelib}/%{vdsm_name}/supervdsm.py* -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
