Piotr Kliczewski has posted comments on this change. Change subject: ssl: configurable implementation ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/44494/10//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-09-15 14:47:04 +0200 Line 6: Line 7: ssl: configurable implementation Line 8: Line 9: We want to choose ssl implementation during build process. > for what? why do we need to different implementation? is it debian support There is custom patch on top of m2c provided by fedora. The patch is not applied for any other distribution and vdsm fails without it. Line 10: Line 11: Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 https://gerrit.ovirt.org/#/c/44494/10/vdsm.spec.in File vdsm.spec.in: Line 1072: %{python_sitelib}/%{vdsm_name}/sslcompat.py* Line 1073: %if %{with_m2c} Line 1074: %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1075: %exclude %{python_sitelib}/%{vdsm_name}/sslutils.py* Line 1076: %else > debian cannot work with the m2c, since we depend on fedora/el version which I do not want to introduce different approaches for different OSes. In my opinion we should have the same behavior for debian and fedora so if we do not have m2c based ssl in one than we should exclude it in the other. I goal here is to be consistent. Line 1077: %exclude %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1078: %{python_sitelib}/%{vdsm_name}/sslutils.py* Line 1079: %endif Line 1080: %{python_sitelib}/%{vdsm_name}/supervdsm.py* -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
