Nir Soffer has posted comments on this change.

Change subject: ssl: configurable implementation
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/44494/10/vdsm.spec.in
File vdsm.spec.in:

Line 1072: %{python_sitelib}/%{vdsm_name}/sslcompat.py*
Line 1073: %if %{with_m2c}
Line 1074: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1075: %exclude %{python_sitelib}/%{vdsm_name}/sslutils.py*
Line 1076: %else
> you introduce something much bigger - different installation tree between d
Yaniv, we cannot ship vdsm on debian using m2c, since our code is not 
compatible with m2c on debian. The only option is to ship only ssl and the 
default on debian can be only ssl.

On rpm based systems, we can choose any default.
Line 1077: %exclude %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1078: %{python_sitelib}/%{vdsm_name}/sslutils.py*
Line 1079: %endif
Line 1080: %{python_sitelib}/%{vdsm_name}/supervdsm.py*


-- 
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to