Dan Kenigsberg has submitted this change and it was merged. Change subject: fileSD.getDomUuidFromMetafilePath: return correct sdUUID ......................................................................
fileSD.getDomUuidFromMetafilePath: return correct sdUUID Since commit 7ce1a3d53, getDomUuidFromMetafilePath() returns a constant string "dom_md", regardless of the storage domain metafile it receives. This has serious effects, since it leads to all NFS domains using a single process pool. It would probably be better to solve the problem by avoiding getDomUuidFromMetafilePath altogether. The callers high up the stack know the sdUUID they are working on. This solution is left as an excersice to the readers. A simpler, localized, solution is to take the correct element out of metafile path. In this patch I suggest to do it without worrying about trailing slashes in the [irs]repository configurable. Thanks to Shu Ming for reporting this bug and suggesting another fix for it. Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7 Signed-off-by: Shu Ming <[email protected]> Signed-off-by: Dan Kenigsberg <[email protected]> --- M vdsm/storage/fileSD.py 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Federico Simoncelli: Looks good to me, approved Dan Kenigsberg: Verified -- To view, visit http://gerrit.ovirt.org/7078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
