Alon Bar-Lev has posted comments on this change. Change subject: vdsm bootstrap changes for kvm on ppc64 support ......................................................................
Patch Set 6: (1 inline comment) .................................................... File vds_bootstrap/vds_bootstrap.py Line 300: self.res = "Intel" Line 301: elif "AuthenticAMD" == deployUtil.cpuVendorID(): Line 302: self.res = "AMD" Line 303: elif "IBM_POWER" == deployUtil.cpuVendorID(): Line 304: self.res = "IBM" If we do not detect the CPU, I think we should fail... self.rc = False, as we cannot actually predict what implication the configuration will be. Why don't you think it is not critical? Line 305: Line 306: if self.vt_svm is None: Line 307: self.vt_svm = "NA" Line 308: -- To view, visit http://gerrit.ovirt.org/7072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Pradipta Banerjee <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
