Dan Kenigsberg has posted comments on this change. Change subject: vdsm bootstrap changes for kvm on ppc64 support ......................................................................
Patch Set 7: (1 inline comment) .................................................... File vdsm_reg/deployUtil.py.in Line 37: import httplib Line 38: import glob Line 39: import imp Line 40: from optparse import OptionParser Line 41: import platform I like code reuse. Thanks! However, please split this change into a separate patch. it is not ppc64-specific. Splitting to small topics my review. Line 42: Line 43: try: Line 44: from ovirtnode import ovirtfunctions Line 45: except ImportError: -- To view, visit http://gerrit.ovirt.org/7072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Pradipta Banerjee <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
