Rodrigo Trujillo has posted comments on this change.

Change subject: vdsm bootstrap changes for kvm on ppc64 support
......................................................................


Patch Set 7: Fails; I would prefer that you didn't submit this

(1 inline comment)

Tested in Fedora 17 PPC64

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 854:         config = ConfigParser.ConfigParser()
Line 855:         config.read(VDSM_CONF)
Line 856:         try:
Line 857:             tsDir = config.get('vars', 'trust_store_path')
Line 858:         except:
You must add a fedora checking  here.
Otherwise VDSM will not find the the key and will not register in ovirt-engine
Line 859:             if rhel6based:
Line 860:                 tsDir = '/etc/pki/vdsm'
Line 861:             else:
Line 862:                 tsDir = '/var/vdsm/ts'


--
To view, visit http://gerrit.ovirt.org/7072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Rodrigo Trujillo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to