Ryan Harper has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Code looks fine, but I'd like to get some documentation for the regular
expression.
....................................................
File vdsm_reg/deployUtil.py.in
Line 103: ([A-Za-z0-9+/]+={0,2})
Line 104: (\s+[^\s]+)?
Line 105: \s*
Line 106: $
Line 107: """)
I couldn't find a standard package or manpage that provided validation for this
RE. Is this documented somewhere?
I also failed to find any command line tools we might use to process the string
an confirm it's a public key. I would like to ensure we're happy with the RE.
Line 108:
Line 109: #
Line 110: # Script interface to use, required for
Line 111: # multi-engine version support.
--
To view, visit http://gerrit.ovirt.org/8018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
