Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 103: ([A-Za-z0-9+/]+={0,2})
Line 104: (\s+[^\s]+)?
Line 105: \s*
Line 106: $
Line 107: """)
Juan,
Why not add https://engine.example.com/getResource?id=engine-ssh
And return either json or xml or anything python can read?
This way we can verify that we are getting valid response...
Also, as this is for vdsm-reg, I would not put this in handleSSHKey() as the
validation should take place when downloading not when using... as within
regular path we push the key to the host.
What do you think?
Line 108:
Line 109: #
Line 110: # Script interface to use, required for
Line 111: # multi-engine version support.
--
To view, visit http://gerrit.ovirt.org/8018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
