Adam Litke has posted comments on this change.
Change subject: Add an option to create a watchdog device.
......................................................................
Patch Set 10: (3 inline comments)
Just some minor formatting issues in the schema. Looks good otherwise. Have
you verified it?
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2220: #
Line 2221: # @i6300esb: the recommended device, emulating a PCI Intel 6300ESB
Line 2222: #
Line 2223: # @IB700: emulating an ISA iBase IB700 as watchdog
Line 2224: #
Please align the descriptions so they all start at the same column. See the
rest of the file for how it's done. Sorry to be pedantic, but the rest of the
file looks so nice :)
Line 2225: # Since: 4.10.0
Line 2226: ##
Line 2227: {'enum': 'VmWatchdogDeviceModel', 'data': ['i6300esb', 'IB700']}
Line 2228:
Line 2233: #
Line 2234: # @reset: default, forcefully reset the guest
Line 2235: #
Line 2236: # @shutdown: gracefully shutdown the guest (not recommended)
Line 2237: #
alignment.
Line 2238: # @poweroff: forcefully power off the guest
Line 2239: #
Line 2240: # @pause: pause the guest
Line 2241: #
Line 2277: #
Line 2278: # @specParams: #optional Additional device parameters
Line 2279: #
Line 2280: # @deviceId: A unique ID for this device
Line 2281: #
These are aligned the way they should be.
Line 2282: # Since: 4.10.0
Line 2283: ##
Line 2284: {'type': 'VmWatchdogDevice',
Line 2285: 'data': {'deviceType': 'VmDeviceType', 'device':
'VmWatchdogDeviceType',
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
