Ryan Harper has posted comments on this change. Change subject: Add simple text-based console in vdsClient ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 8: Line 9: Add new command 'openConsole' in vdsClient. This command Line 10: invoke 'virsh console' directly. This is easy implement for text-based Line 11: console. It means we can have a vdsm text console right now. Line 12: We can improve text console in futrue. s/futrue/future. Also, we probably want to update the vdsm.spec file to indicate that vdsm-cli package depends on /bin/virsh. Line 13: Line 14: Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a .................................................... File vdsm_cli/vdsClient.py Line 122: class service: Line 123: def __init__(self): Line 124: self.useSSL = False Line 125: self.truststore = None Line 126: self.server = "0" Anything special about "0" or would None be sufficient? Line 127: Line 128: def do_connect(self, server, port): Line 129: self.server = server Line 130: self.s = vdscli.connect(server + ':' + port, -- To view, visit http://gerrit.ovirt.org/8041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
