ShaoHe Feng has posted comments on this change. Change subject: Add simple text-based console in vdsClient ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm_cli/vdsClient.py Line 1612: Line 1613: def openVmConsole(self, args): Line 1614: protocol = "tls" if self.useSSL else "tcp" Line 1615: conn = "qemu+" + protocol + "://" + self.server + "/system" Line 1616: p = subprocess.Popen(["virsh", "-c", conn, "console", args[0]]) 1. Are libvirtd and virsh in same rpm packet? I did not check this. so, if not, should require virsh be installed? 2. this console is only human or for engine? Line 1617: p.wait() Line 1618: Line 1619: Line 1620: if __name__ == '__main__': -- To view, visit http://gerrit.ovirt.org/8041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
