Saggi Mizrahi has posted comments on this change. Change subject: super vdsm validation of recovery after crash ......................................................................
Patch Set 20: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/supervdsm.py Line 154: raise Line 155: self._svdsm = self._manager.instance() Line 156: Line 157: def launch(self): Line 158: self._launch() Don't use that stupid naming scheme where the a private method has the same name as a public one. either change the private one to startProxy() or change the public one to init(). They can't have the same name if they don't do the same thing! Line 159: utils.retry(self._connect, Exception, timeout=60) Line 160: Line 161: def __getattr__(self, name): Line 162: return ProxyCaller(self, name) -- To view, visit http://gerrit.ovirt.org/7901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
