Shu Ming has posted comments on this change. Change subject: svdsm validation of recovery after crash ......................................................................
Patch Set 16: (2 inline comments) .................................................... File vdsm/supervdsm.py Line 74: try: Line 75: return callMethod() Line 76: # handling internal exception that we raise to identify supervdsm Line 77: # validation. only this exception can cause kill! Line 78: except AuthenticationError: How about the other exceptions? Should we just pass them? Line 79: with _g_singletonSupervdsmInstance_lock: Line 80: self._supervdsmPoxy.kill() Line 81: self._supervdsmProxy.launch() Line 82: return callMethod() .................................................... File vdsm/supervdsmServer.py Line 86: Line 87: class _SuperVdsm(object): Line 88: Line 89: @logDecorator Line 90: def ping(self, *args, **kwargs): Please ignore it, just understand that it only for test purpose. Line 91: # This method purpose to test if svdsm is up and returns after a call Line 92: return True Line 93: Line 94: @logDecorator -- To view, visit http://gerrit.ovirt.org/7901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
