Dan Kenigsberg has posted comments on this change.
Change subject: SuperVdsm validation of recovery after crash
......................................................................
Patch Set 30: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/clientIF.py
Line 454:
Line 455: def _cleanOldFiles(self):
Line 456: known_exts = ("guest.socket", "pid", "recovery")
Line 457: dontDel = ("vdsmd.pid", "respawn.pid", "svdsm.pid",
"svdsm.sock",
Line 458: "svdsm.time")
this is NOT needed, as "time" is not in known_exts.
and more than that - the whole dependency on two unrelated changes (to
cleanOldFiles and rmFile) adds needless complexity.
Line 459:
Line 460: fNames = [fName for fName in os.listdir(constants.P_VDSM_RUN)
Line 461: if fName not in
dontDel]
Line 462: for fName in fNames:
--
To view, visit http://gerrit.ovirt.org/7901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
