Saggi Mizrahi has posted comments on this change.
Change subject: SuperVdsm validation of recovery after crash
......................................................................
Patch Set 29: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/supervdsm.py
Line 86: """
Line 87: A wrapper around all the supervdsm init stuff
Line 88: """
Line 89: _log = logging.getLogger("SuperVdsmProxy")
Line 90: proxyLock = threading.Lock()
Why is it still a class field instead of an instance field
Line 91:
Line 92: def __init__(self):
Line 93: self._firstLaunch = True
Line 94:
Line 96: return self._manager.open(*args, **kwargs)
Line 97:
Line 98: def _cleanOldFiles(self):
Line 99: self._log.warn("Cleanning svdsm old files: %s, %s, %s",
Line 100: PIDFILE, TIMESTAMP, ADDRESS)
Why is that warning or even note worthy?
Line 101: utils.rmFile(PIDFILE)
Line 102: utils.rmFile(TIMESTAMP)
Line 103: utils.rmFile(ADDRESS)
Line 104:
--
To view, visit http://gerrit.ovirt.org/7901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
