Dan Kenigsberg has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56365/1//COMMIT_MSG Commit Message: Line 19: This functionality is required to properly let NetworkManager Line 20: know when VDSM consumes any of its devices (on ifcfg systems, Line 21: by writing NM_CONTROLLED=no to an ifcfg file). Line 22: Line 23: TODO: NetworkManager must be restarted after installing you can do that in the spec file's %post script: if you upgrade from a vdsm version that does not have the config files, restart NetworkManager (if it was already running). But this is utterly needless, as at the moment we keep NetworkManager disabled when we add a new host. Line 24: the new configuration file. Line 25: Line 26: Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Line 27: Bug-Url: https://bugzilla.redhat.com/1304509 -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
