Dan Kenigsberg has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56365/2/vdsm.spec.in File vdsm.spec.in: PS2, Line 811: if /bin/systemctl status NetworkManager; then > It is stopped and disabled indeed. In that case this code does nothing. I don't understand why you want to restart NM. Anyway, it is not even running these days. Please do not touch it here. https://gerrit.ovirt.org/#/c/56365/2/vdsm/90-vdsm-monitor-connection-files.conf File vdsm/90-vdsm-monitor-connection-files.conf: Line 1: # This file is necessary to let VDSM properly consume connections owned by Line 2: # NetworkManager (to make it unmanage them), primarily on ifcfg systems. Line 3: Line 4: [main] Line 5: monitor-connection-files=true > Yes, 'nmcli conn reload' was made for this purpose. beyond the problem of writing partial files to disk, I'm worried about changing a slave's ifcfg and only later the ifcfg of a bridge. I hope that we can start using synchronous nm-cli in the future. -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches