Zhou Zheng Sheng has posted comments on this change. Change subject: packaging: add a method to reconfigure without init.d parameter ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) We can also add a "reconfigure" command to vdsm-tool based on the work of this patch. .................................................... File vdsm/vdsmd.init.in Line 274: Line 275: # Line 276: # reconfigure if: Line 277: # - force specified or Line 278: # - we have the FORCE_RECONFIGURE trigger file When I firstly read this code and the comment, I got a little bit confused, then realized what it means. An "or" is at the end of "force specified or", maybe also add an "or" to "we have the FORCE_RECONFIGURE trigger file" is more readable. Line 279: # - not configured Line 280: # Line 281: if [ "$force_reconfigure" != "force" ] && Line 282: ! [ -f "$FORCE_RECONFIGURE" ] && -- To view, visit http://gerrit.ovirt.org/8725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a8d5939fbefc6d3857d8083dfcf2180b9ba110 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
