Dan Kenigsberg has submitted this change and it was merged.

Change subject: packaging: add a method to reconfigure without init.d parameter
......................................................................


packaging: add a method to reconfigure without init.d parameter

systemd does not support additional service commands[1], while there can
be argue if this is good or bad this is the fact.

CURRENT IMPLEMENTATION

Current bootstrap implementation uses hybrid approach while trying to
pass "reconfigure" to init.d, and when fails, access the init.d script
directly.

This is highly none expected behavior.

NEW IMPLEMENTATION

Add /var/lib/vdsm/reconfigure file, if exists perform reconfiguration.

This will work with any init.d system without issues.

The service will be reconfigure at next start.

** We cannot remove the code from the current vdsm-bootstrap, so it able
   to reconfigure previous versions of vdsm.

[1] http://www.freedesktop.org/wiki/Software/systemd/Incompatibilities

Change-Id: Id4a8d5939fbefc6d3857d8083dfcf2180b9ba110
Signed-off-by: Alon Bar-Lev <[email protected]>
---
M vdsm/vdsmd.init.in
1 file changed, 18 insertions(+), 1 deletion(-)

Approvals:
  Alon Bar-Lev: Verified
  Adam Litke: Looks good to me, but someone else must approve
  Juan Hernandez: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/8725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4a8d5939fbefc6d3857d8083dfcf2180b9ba110
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to