Dan Kenigsberg has posted comments on this change. Change subject: packaging: add a method to reconfigure without init.d parameter ......................................................................
Patch Set 2: (1 inline comment) this patch would work - but how about a different approach, of factoring "reconfigure" into a separate script (maybe even in vdsm-tool?) which is accessible for external usage? wouldn't it be simpler to run such a script, rather than touching a file and restarting vdsm? .................................................... File vdsm/vdsmd.init.in Line 274: Line 275: # Line 276: # reconfigure if: Line 277: # - force specified or Line 278: # - we have the FORCE_RECONFIGURE trigger file I agree that a trailing "or" is missing here (though defining a function is_configured and putting the grep's in it would have been better than any commenting. I cannot say that I like duplicating bash logic in English) Line 279: # - not configured Line 280: # Line 281: if [ "$force_reconfigure" != "force" ] && Line 282: ! [ -f "$FORCE_RECONFIGURE" ] && -- To view, visit http://gerrit.ovirt.org/8725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a8d5939fbefc6d3857d8083dfcf2180b9ba110 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
