Alon Bar-Lev has posted comments on this change. Change subject: packaging: add a method to reconfigure without init.d parameter ......................................................................
Patch Set 2: (1 inline comment) The idea of putting this on service is that on first run (reboot) it configure it-self. We can move the logic into a tool, and have the service call this tool. However you don't want to reconfigure while service is running... so either the tool stops the service if executed manually or it still put some trigger. .................................................... File vdsm/vdsmd.init.in Line 274: Line 275: # Line 276: # reconfigure if: Line 277: # - force specified or Line 278: # - we have the FORCE_RECONFIGURE trigger file I will put here anything you guys think appropriate or just delete the comment :) Line 279: # - not configured Line 280: # Line 281: if [ "$force_reconfigure" != "force" ] && Line 282: ! [ -f "$FORCE_RECONFIGURE" ] && -- To view, visit http://gerrit.ovirt.org/8725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a8d5939fbefc6d3857d8083dfcf2180b9ba110 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
