Mark Wu has posted comments on this change.
Change subject: storage: set block schedule elevator using udev
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I agree with that the using udev is better than grub conf. Just a minor
suggestion inline.
....................................................
File vdsm/storage/12-vdsm-elevator.rules
Line 8: #
Line 9:
Line 10: # Udev rules for elevator setting.
Line 11:
Line 12: ACTION=="add|change", SUBSYSTEM=="block", ENV{DEVTYPE}=="disk",
RUN+="vdsm-elevator.sh deadline"
I think we can just use a command line instead of adding new script, like:
RUN+="/bin/sh -c 'echo deadline > /sys$DEVPATH/queue/scheduler'"
For dm devices, we can filter out them by udev key word or just write it
unconditionally.
--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
