Dan Kenigsberg has posted comments on this change.

Change subject: storage: set block schedule elevator using udev
......................................................................


Patch Set 1:

Alon, I think that what troubles Ayal is that currently, if someone was not 
happy with our block scheduler of choice, he could edit his /etc/grub.conf, and 
walk away.

With your patch, this is impossible. We change the system scheduler, and as 
long as vdsm is installed, that's that.

Maybe, if you can find a way to limit the udev rule to ovirt-owned block 
devices, Ayal would have been happier. (I do not have a shred of an idea how to 
do this properly. How about a user-editable blacklist of devices were 
vdsm-elevator.rules does not apply?)

--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to